search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
457 stars 304 forks source link

Remove legacy code, PROJECT_PATH and related test case code_tests #5429

Closed benjaoming closed 7 years ago

benjaoming commented 7 years ago

Summary

Removes broken code in 'setup' management command

Targeting for 0.17.1 because there are no current plans for 0.18, and this is just a legacy cleanup.

TODO

Reviewer guidance

As noted in the release notes, PROJECT_PATH was not even configurable. It was used wrongly, too. Its default value was the KALITE_HOME environment, but some places of usage assumed it would be a "project root", which is a remnant of when KA Lite was distributed as a static directory.

Issues addressed

4104

codecov-io commented 7 years ago

Codecov Report

Merging #5429 into 0.17.x will increase coverage by <.01%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.17.x    #5429      +/-   ##
==========================================
+ Coverage   51.76%   51.77%   +<.01%     
==========================================
  Files         143      143              
  Lines        7499     7496       -3     
==========================================
- Hits         3882     3881       -1     
+ Misses       3617     3615       -2
Impacted Files Coverage Δ
kalite/settings/base.py 88.67% <ø> (-0.11%) :arrow_down:
...ite/distributed/management/commands/screenshots.py 0% <0%> (ø) :arrow_up:
kalite/distributed/management/commands/setup.py 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b438691...97b4a18. Read the comment docs.