learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 304 forks source link

Coach reports date filtering and exercise summaries #5435

Closed benjaoming closed 7 years ago

benjaoming commented 7 years ago

Summary

Not super happy about the state of coach reports - however these small improvements should get us a bit closer to having a properly functioning coach reports display.

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

Reviewer guidance

Not expecting reviews, will rely on tests

Issues addressed

5020

5022

codecov-io commented 7 years ago

Codecov Report

Merging #5435 into 0.17.x will decrease coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.17.x    #5435      +/-   ##
==========================================
- Coverage   51.77%   51.72%   -0.06%     
==========================================
  Files         143      143              
  Lines        7494     7494              
==========================================
- Hits         3880     3876       -4     
- Misses       3614     3618       +4
Impacted Files Coverage Δ
kalite/coachreports/api_views.py 90.76% <100%> (-3.08%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8da5fa5...dd2bd91. Read the comment docs.

benjaoming commented 7 years ago

Hurray, tests have passed