Closed benjaoming closed 7 years ago
Merging #5441 into 0.17.x will increase coverage by
0.2%
. The diff coverage is8.47%
.
@@ Coverage Diff @@
## 0.17.x #5441 +/- ##
=========================================
+ Coverage 51.73% 51.94% +0.2%
=========================================
Files 143 143
Lines 7494 7466 -28
=========================================
+ Hits 3877 3878 +1
+ Misses 3617 3588 -29
Impacted Files | Coverage Δ | |
---|---|---|
...stributed/management/commands/initialize_kalite.py | 0% <0%> (ø) |
:arrow_up: |
kalite/distributed/management/commands/setup.py | 0% <0%> (ø) |
:arrow_up: |
kalite/settings/base.py | 88.78% <75%> (+0.1%) |
:arrow_up: |
kalite/cli.py | 29.03% <9.52%> (-0.11%) |
:arrow_down: |
kalite/distributed/views.py | 59.23% <0%> (-0.64%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a5fbd46...17e2754. Read the comment docs.
Doesn't seem like it's possible to trick Codecov into a new coverage report, leaving it here.
Taking over from #5438
Summary
This also (once again) prints the server address at command line ( a regression from #5364 )
TODO
If not all TODOs are marked, this PR is considered WIP (work in progress)
Reviewer guidance
Let me know if there are problems in this approach. I don't see much of a difference, except I forced ALL of the loggers in
kalite.distributed.management.commands
to user a logger WITHOUT formatting, expecting their outputs to be generally targeted for command line displaying.However, they are also subject to be printed in the server log.
Issues addressed
5408