search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 304 forks source link

Run coverage in parallel mode #5443

Closed benjaoming closed 7 years ago

benjaoming commented 7 years ago

Summary

Been wondering a bit why coverage isn't showing up properly for kalite.cli so trying out this, even though I think CodeCov already knows that it's receiving separate reports from both CircleCI instances...

codecov-io commented 7 years ago

Codecov Report

Merging #5443 into 0.17.x will decrease coverage by 3.91%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.17.x    #5443      +/-   ##
==========================================
- Coverage   51.94%   48.02%   -3.92%     
==========================================
  Files         143      120      -23     
  Lines        7466     6599     -867     
==========================================
- Hits         3878     3169     -709     
+ Misses       3588     3430     -158
Impacted Files Coverage Δ
kalite/cli.py 28.94% <0%> (-0.1%) :arrow_down:
kalite/inline/api_urls.py 100% <0%> (ø) :arrow_up:
kalite/inline/narratives.py 100% <0%> (ø) :arrow_up:
kalite/updates/urls.py 100% <0%> (ø) :arrow_up:
kalite/distributed/forms.py 100% <0%> (ø) :arrow_up:
kalite/contentload/api_urls.py 100% <0%> (ø) :arrow_up:
kalite/coachreports/api_urls.py 100% <0%> (ø) :arrow_up:
kalite/control_panel/urls.py 100% <0%> (ø) :arrow_up:
kalite/distributed/features/steps/generic.py
kalite/coachreports/features/steps/coachreports.py
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 062188a...b848fe4. Read the comment docs.

benjaoming commented 7 years ago

Merging #5443 into 0.17.x will decrease coverage by 0.01%.

facepalm

benjaoming commented 7 years ago

Merging #5443 into 0.17.x will decrease coverage by 3.98%. The diff coverage is n/a.

facepalm

benjaoming commented 7 years ago

Wat on earth

Merging #5443 into 0.17.x will decrease coverage by 4.55%. The diff coverage is n/a.

benjaoming commented 7 years ago

I understand now that the decrease in coverage is because I started ignoring BDD test steps and features, which had pretty high 'coverage' (because they were the test code).

benjaoming commented 7 years ago

I can see coverage of kalite.cli locally but not in the online CodeCov report. Closing this PR and opening a new one in order to figure out if CodeCov isn't doing what it's supposed to.