learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 304 forks source link

Add line breaks in buttons so text isn't cut #5448

Closed benjaoming closed 7 years ago

benjaoming commented 7 years ago

Summary

Simple fix. Hopefully it doesn't break other aspects of our buttons, but manual tests of the next prerelease will have to verify this @radinamatic

Otherwise, this is easy to revert.

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

Reviewer guidance

None, will be thoroughly tested in the prerelease

Issues addressed

5004

benjaoming commented 7 years ago

Wrap looks like this:

screenshot from 2017-04-14 23-39-30

codecov[bot] commented 7 years ago

Codecov Report

Merging #5448 into 0.17.x will decrease coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.17.x    #5448      +/-   ##
==========================================
- Coverage   61.39%   61.37%   -0.02%     
==========================================
  Files         118      118              
  Lines        6574     6574              
==========================================
- Hits         4036     4035       -1     
- Misses       2538     2539       +1
Impacted Files Coverage Δ
kalite/cli.py 42.35% <ø> (ø) :arrow_up:
kalite/coachreports/models.py 84.95% <0%> (-0.89%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0786c8c...5b61330. Read the comment docs.