search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 304 forks source link

Log rotation #5449

Closed benjaoming closed 7 years ago

benjaoming commented 7 years ago

Summary

This is a new feature, but I'm going for 0.17.1 because it's super important to have logs for stuff.. especially tech support.

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

Reviewer guidance

We might wanna make extra sure that this works on Windows, but I don't think there's a lot to review here.. I've manually tried it out, and it works :) But all the tests will end up logging things, too!

Issues addressed

4890

codecov[bot] commented 7 years ago

Codecov Report

Merging #5449 into 0.17.x will increase coverage by <.01%. The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.17.x    #5449      +/-   ##
==========================================
+ Coverage   61.39%   61.39%   +<.01%     
==========================================
  Files         118      118              
  Lines        6574     6577       +3     
==========================================
+ Hits         4036     4038       +2     
- Misses       2538     2539       +1
Impacted Files Coverage Δ
kalite/cli.py 42.35% <20%> (ø) :arrow_up:
kalite/settings/base.py 88.18% <75%> (-0.61%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8bce7a7...9e497df. Read the comment docs.

benjaoming commented 7 years ago

The lack of coverage in cli.py has to be accepted.. my static code checker says it's fine.

benjaoming commented 7 years ago

Merging this in due time for 0.17.1