search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 304 forks source link

Update MacOS uninstall documentation #5451

Closed mrpau-eduard closed 7 years ago

mrpau-eduard commented 7 years ago

Summary

This will update the macOS uninstall documentation. This include two option how to uninstall the KA Lite in your macOS via KA Lite Preferences or KA-Lite_Uninstall.tool

Issues addressed

https://github.com/learningequality/ka-lite-installers/issues/446

5440

codecov[bot] commented 7 years ago

Codecov Report

Merging #5451 into 0.17.x will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.17.x    #5451   +/-   ##
=======================================
  Coverage   61.39%   61.39%           
=======================================
  Files         118      118           
  Lines        6577     6577           
=======================================
  Hits         4038     4038           
  Misses       2539     2539

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b181b9...f8cfe95. Read the comment docs.

mrpau-eduard commented 7 years ago

Hi @benjaoming I updated the installation docs based on your suggestion can you take a look at it again? Thank you for reviewing it :)

mrpau-eduard commented 7 years ago

Done removing the redundant step @benjaoming .

benjaoming commented 7 years ago

Done removing the redundant step @benjaoming

You missed my last comment ;)

benjaoming commented 7 years ago

Cool - @mrpau-eduard could you compress everything into a single commit?

See: https://makandracards.com/makandra/527-squash-several-git-commits-into-a-single-commit

benjaoming commented 7 years ago

@mrpau-eduard I've edited my above response, was putting some incomplete steps, better to just read the guide..