search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 304 forks source link

Points keep increasing even when the user is just replaying the video. #5458

Closed mrpau-eugene closed 7 years ago

mrpau-eugene commented 7 years ago

Summary

I was watching some videos because I was trying to reproduce this issue #4302. I thought each video is allocated with an equivalent number of points. So when I am halfway through finishing the video, I tried to replay it. And I have observed that the points keep increasing.

System information

How to reproduce

  1. Login as User
  2. Watch a Video
  3. Look at how the points are increasing
  4. Repeat the video from the start

Screenshots

may-05-2017 11-39-11

Expected Behavior: The points should reset to 0 or to the equivalent seconds where the video was replayed. Actual Behavior: The points keep on increasing.

Update: The points that are increasing does not reflect to the total points accumulated by the learner. My bad. I'll just close this issue.

jamalex commented 7 years ago

Thanks for the report! This is actually the expected behavior, even if it seems less than ideal. Keeping track of exactly which time ranges have been viewed and trying to make sure we only allocate points for new sections of the video would be too burdensome. All we store in the DB is how many total seconds (in "video time") each video was watched for.

mrpau-eugene commented 7 years ago

thanks for the clarification @jamalex

benjaoming commented 7 years ago

Yup, it's not optimal, but not something that's really causing any breakage.. essentially students can access videos, solve exercises, and teachers can monitor student progress... despite this strange behaviour :)

But great issue report @mrpau-eugene - really good start - you've reported and solved an issue in almost no time :+1: :smile: