Closed benjaoming closed 7 years ago
Merging #5460 into 0.17.x will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## 0.17.x #5460 +/- ##
=======================================
Coverage 61.39% 61.39%
=======================================
Files 118 118
Lines 6577 6577
=======================================
Hits 4038 4038
Misses 2539 2539
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f6ce18c...290c588. Read the comment docs.
Summary
I found a bunch of things that were hard to read or badly structured, so did a bit of clean up.
Ultimately, I think we should get rid of
install_all
because it's way too long and cluttered.TODO
If not all TODOs are marked, this PR is considered WIP (work in progress)
Reviewer guidance
Maybe look for typos :)
Issues addressed
5459