search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 304 forks source link

Bump version of ifcfg #5463

Closed benjaoming closed 7 years ago

benjaoming commented 7 years ago

Summary

Updated python-ifcfg to 0.10 and released on PyPi through https://github.com/learningequality/python-ifcfg/issues/3

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

Reviewer guidance

Haven't tested this yet on affected systems (Ubuntu 17.04+)

Issues addressed

Fixes #5455

codecov[bot] commented 7 years ago

Codecov Report

Merging #5463 into 0.17.x will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.17.x    #5463      +/-   ##
==========================================
+ Coverage   61.36%   61.38%   +0.01%     
==========================================
  Files         118      118              
  Lines        6572     6572              
==========================================
+ Hits         4033     4034       +1     
+ Misses       2539     2538       -1
Impacted Files Coverage Δ
kalite/version.py 100% <100%> (ø) :arrow_up:
kalite/coachreports/models.py 85.84% <0%> (+0.88%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5a18b3...32ba6d2. Read the comment docs.

benjaoming commented 7 years ago

Tested a local build in Ubuntu 17.04, and it works - so I dare merge this now and assume the bug is fixed.