Closed mrpau-eduard closed 7 years ago
Merging #5474 into 0.17.x will decrease coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## 0.17.x #5474 +/- ##
==========================================
- Coverage 61.39% 61.38% -0.02%
==========================================
Files 118 118
Lines 6572 6572
==========================================
- Hits 4035 4034 -1
- Misses 2537 2538 +1
Impacted Files | Coverage Δ | |
---|---|---|
kalite/distributed/views.py | 77.7% <0%> (-1.28%) |
:arrow_down: |
kalite/coachreports/models.py | 85.84% <0%> (+0.88%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0dd7ebe...0e1a707. Read the comment docs.
Hi @benjaoming done updating the PR
can you take a look again.
you can check the build artifact here https://buildkite.com/learningequality/ka-lite/builds/69#9ebc63e1-3142-4fd4-8ce7-411a38d9ffe0
@mrpau-eduard I grabbed the exe
artifact to test but I'm guessing that it is not fully functional yet, since it skipped the whole ka-lite-static
part of installation and server could not start afterwards:
@mrpau-eduard I see that you requested a review, but is there a new build apart from the one I tested yesterday?
Hi @radinamatic I am currently replicating the issue on the windows installer.
I found some issue during installing the whl
file, but If I install thewhl
file on the terminal manually it is working.
Ok, ping me when there is a build for me to poke and prod! :wink:
I was able to replicate the issue:
The issue here is ka_lite_static-0.17.2.dev1-py2-none-any.whl
is a wrong filename. Since the ka-lite-installer for windows assume that the filename is correct. It uses the kalite.version
as the build identifier for each installer.
I try to bump the VERSION 0.17.2dev1
into 0.17.2
and it work.
You can grab the installer here
https://buildkite.com/learningequality/ka-lite/builds/73#17bc8ae0-fba9-4dd5-b755-80070fdc90f4
@mrpau-eduard Looking good! With this latest build everything seems to install correctly, and no static files are missing! :+1:
Is it my impression or the installation takes longer now? I tested on Windows 7... :thinking:
Great work @mrpau-eduard - Now that it's merged to 0.17.x, will you be able to try it out with Buildkite and switch it on for PRs?
It would be nice if the builds are made available through PR status - and not with a comment for every commit :) @rtibbles has made this work for Kolibri.
Summary
This is implemented also on kolibri and will implement also on ka-lite.
TODO
Issues addressed
5473