Closed mrpau-eugene closed 7 years ago
Good one @mrpau-eugene - a screenshot would be nice too. 😸
done adding a screenshot @cpauya
Merging #5475 into 0.17.x will increase coverage by
0.45%
. The diff coverage is61.11%
.
@@ Coverage Diff @@
## 0.17.x #5475 +/- ##
==========================================
+ Coverage 61.39% 61.85% +0.45%
==========================================
Files 118 118
Lines 6572 6582 +10
==========================================
+ Hits 4035 4071 +36
+ Misses 2537 2511 -26
Impacted Files | Coverage Δ | |
---|---|---|
kalite/distributed/urls.py | 95.65% <ø> (ø) |
:arrow_up: |
kalite/distributed/views.py | 78.65% <100%> (-0.33%) |
:arrow_down: |
kalite/cli.py | 50.94% <36.36%> (+8.9%) |
:arrow_up: |
kalite/inline/api_views.py | 35.71% <0%> (-57.15%) |
:arrow_down: |
kalite/main/api_views.py | 87.71% <0%> (-1.76%) |
:arrow_down: |
kalite/coachreports/models.py | 85.84% <0%> (+0.88%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0dd7ebe...ad63a83. Read the comment docs.
Merging #5475 into 0.17.x will increase coverage by
0.59%
. The diff coverage is58.82%
.
@@ Coverage Diff @@
## 0.17.x #5475 +/- ##
==========================================
+ Coverage 61.39% 61.98% +0.59%
==========================================
Files 118 118
Lines 6572 6582 +10
==========================================
+ Hits 4035 4080 +45
+ Misses 2537 2502 -35
Impacted Files | Coverage Δ | |
---|---|---|
kalite/distributed/urls.py | 95.65% <ø> (ø) |
:arrow_up: |
kalite/distributed/views.py | 78.65% <100%> (-0.33%) |
:arrow_down: |
kalite/cli.py | 50.94% <30%> (+8.9%) |
:arrow_up: |
kalite/coachreports/models.py | 85.84% <0%> (+0.88%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0dd7ebe...2fde371. Read the comment docs.
@mrpau-eugene great work!!
I guess the last little thing would be to have a test - perhaps you can just make a simple view test that checks that diagnostics do load eventually?
Reviewed the CodeCov report and it seems something is messed up with the metrics, like it's outlining lines that are completely untouched by this PR.
So merging because tests pass!
Summary
A page which displays the output from![screen shot 2017-06-21 at 3 27 19 pm](https://user-images.githubusercontent.com/27984604/27372177-3d125116-5696-11e7-9a64-3c526e175565.png)
kalite diagnose
TODO
If not all TODOs are marked, this PR is considered WIP (work in progress)
Issues addressed
5452