learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity

https://learningequality.org/ka-lite/

Other

456 stars 306 forks source link

Translation updates #5485

Closed benjaoming closed 6 years ago

benjaoming commented 7 years ago

Summary

Documentation
Make target msgids for generating translation sources
Do not hide "IGNORE_PATTERNS" in a Python file, moved them to the Makefile
Adds the sources to the repo so we can track them moving forwards

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

[x] Has documentation been written/updated?
[x] Have you written release notes for the upcoming release?

Reviewer guidance

Let me know if I missed something in the way we generate msgids!

Issues addressed

5477

codecov[bot] commented 7 years ago

Codecov Report

Merging #5485 into 0.17.x will increase coverage by 0.34%. The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           0.17.x    #5485      +/-   ##
==========================================
+ Coverage   61.98%   62.33%   +0.34%     
==========================================
  Files         118      118              
  Lines        6582     6582              
==========================================
+ Hits         4080     4103      +23     
+ Misses       2502     2479      -23

Impacted Files	Coverage Δ
kalite/i18n/management/commands/makemessages.py	`95.83% <93.75%> (+95.83%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc1d108...c6d6daa. Read the comment docs.

radinamatic commented 6 years ago

OK, we are not done with this, yet...

This is what the Coach tools looks like after updating to the latest content pack in Spanish

virtualbox_ubuntu17 04_28_07_2017_19_06_18

Strings still in English:

All selected inside the topic selector and the Submit button. Search string inside the search field. N/A value for the summary of total hours on content compared to total hours connected. Key string for the tabular report colors.

Disregard the strings with orange overlay, as that is a different issue (already reported), which we have to correct nevertheless... :wink:

@mrpau-eduard @benjaoming I believe we should correct this too, before releasing 0.17.2.

benjaoming commented 6 years ago

@radinamatic

Some of these examples are unfortunately from JS libraries that aren't translated:

All selected is from node_modules/bootstrap-multiselect/dist/js/bootstrap-multiselect.js
Search is from node_modules/bootstrap-multiselect/dist/js/bootstrap-multiselect.js

I've opened #5496 for the two others.