search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
458 stars 305 forks source link

Resource titles displaying in English instead of the chosen locale in the Teach tab #5494

Closed radinamatic closed 7 years ago

radinamatic commented 7 years ago

Summary

If Spanish is selected by default, the resource titles are still displaying in English instead of Spanish inside the search dropdown and tabular report in the Teach tab.

This does not seem to be a contentpack issue as those items are present and localized in the Spanish topic tree, they are just not displaying here in the appropriate language, whether Spanish or French.

System information

How to reproduce

  1. Log-in as one or more users, view some videos, or do some exercises
  2. Login as Admin or Coach
  3. Change the locale.
  4. Go to Teach tab and observe the tabular report at the bottom.

Screenshots

Spanish

virtualbox_ubuntu17 04_28_07_2017_19_06_18-titles

French

virtualbox_ubuntu17 04_29_07_2017_04_03_35

Real-life consequences

Coaches cannot interpret the results - let's fix it with the rest of the content in Spanish that we already managed to correct!

mrpau-eugene commented 7 years ago

Btw, this issue is also existing in the demo server.

I tried adding _ in some variables in the tabular-view.handlebars but it still doesn't seem to get translated.

Correct me if I'm wrong, but I think the behavior on how we fetch the data is that it fetches the contents from the english database and not from spanish, french, etc.

@benjaoming do you have any other ideas why this happens?

benjaoming commented 7 years ago

Btw, this issue is also existing in the demo server.

The demo server is running 0.16.9 which probably have similar issues.

I tried adding _ in some variables in the tabular-view.handlebars but it still doesn't seem to get translated.

These titles are from the content database, so isn't the problem that it uses the English contents regardless of the active user language?

benjaoming commented 7 years ago

Also, @mrpau-eugene - some of the missing msgids are added in #5496

mrpau-eugene commented 7 years ago

These titles are from the content database, so isn't the problem that it uses the English contents regardless of the active user language?

Yes, that's most likely it.

Also, @mrpau-eugene - some of the missing msgids are added in #5496

Great! Will see if I can also find some missing msgids :)

radinamatic commented 7 years ago

@mrpau-eugene

so isn't the problem that it uses the English contents regardless of the active user language?

Yes, that's most likely it.

I hope I'm understanding correctly: what you want to say is that it isn't going to be a (big) problem to fix, right?

Because it is definitely a problem for the users to have them in English instead of the active user language... :stuck_out_tongue:

mrpau-eugene commented 7 years ago

@radinamatic Yeah. Seems like it won't take too long. I'll fix this as soon as possible.

mrpau-eugene commented 7 years ago

@radinamatic @benjaoming where should we target a PR for this? Should it be in the 0.17.3?

radinamatic commented 7 years ago

Is there a reason why it should not be included into the 0.17.2? Partners in LatAm are expecting it... :confused:

mrpau-eugene commented 7 years ago

@radinamatic no reason in particular.. I'm just making sure 😄

benjaoming commented 7 years ago

I'm happy to add this in 0.17.2 since the fix is very clean. Will verify the CI build and merge soon.