search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
458 stars 305 forks source link

Re-arrange CI test build steps #5503

Closed benjaoming closed 7 years ago

benjaoming commented 7 years ago

Move a bunch of dependency setup that affects all containers to the dependency build so the build fails when any of these steps fail

Before, our builds would continue even though JS asset building had failed. Which created a lot of confusing errors in Selenium tests.

codecov[bot] commented 7 years ago

Codecov Report

Merging #5503 into 0.17.x will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.17.x    #5503   +/-   ##
=======================================
  Coverage   62.77%   62.77%           
=======================================
  Files         117      117           
  Lines        6555     6555           
=======================================
  Hits         4115     4115           
  Misses       2440     2440

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e437ab...8dabc64. Read the comment docs.

benjaoming commented 7 years ago

Since this passes tests, I'm merging it!