search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
458 stars 305 forks source link

Remove color legends #5511

Closed mrpau-eugene closed 7 years ago

mrpau-eugene commented 7 years ago

Summary

@radinamatic suggested to unify the Color Legends together with the Keys

Issues addressed

List the issues solved or partly solved by the PR

5510

5494

codecov[bot] commented 7 years ago

Codecov Report

Merging #5511 into 0.17.x will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.17.x    #5511   +/-   ##
=======================================
  Coverage   62.77%   62.77%           
=======================================
  Files         117      117           
  Lines        6555     6555           
=======================================
  Hits         4115     4115           
  Misses       2440     2440
Impacted Files Coverage Δ
kalite/distributed/views.py 78.65% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c068e2...266c81b. Read the comment docs.

radinamatic commented 7 years ago

I wasn't able to confirm this fix @mrpau-eugene :disappointed:

Buildkite does not compile installers by default for PRs, I tried (and failed 3 times) to initiate the build myself (Buildkite 3, Radina 0 :rage:).

Then I tried applying the changes from your PR on the VM installations in both Ubuntu (rc2-2) and Windows (dev build from last week). collectstatic was successful on Ubuntu, but not on Windows install, and no changes were visible anywhere.

I might be missing something, could you build the installer so I could test?

mrpau-eugene commented 7 years ago

@radinamatic can you download and test this installer here?

benjaoming commented 7 years ago

Sorry, I can see that it will be pretty annoying to communicate what's going on to someone reading our release notes.

Am merging this for 0.17.3.

Will test.