Closed mrpau-eugene closed 6 years ago
Merging #5517 into 0.17.x will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## 0.17.x #5517 +/- ##
=======================================
Coverage 62.77% 62.77%
=======================================
Files 117 117
Lines 6555 6555
=======================================
Hits 4115 4115
Misses 2440 2440
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 60b3a1a...3a26e38. Read the comment docs.
Oh #facepalm, well there's a pile of additional translations to be dealt with! Nicely spotted, I'll merge and upload the files to CrowdIn.
If we see additional translation activity, we can consider to inject the newly built translations files directly into existing content packs to avoid rebuilding them.
Btw. as the commit message said "Missing translations for *.js files" - this isn't true, it was a few .js messages in webpack bundles.
Btw. as the commit message said "Missing translations for *.js files" - this isn't true, it was a few .js messages in webpack bundles.
Oh, yeah! You're right @benjaoming my bad.
Summary
@rtibbles mentioned that the
IGNORE_PATTERNS
inside theMakefile
ignores the source files for translation. We don't want this to happen.Also, thanks @benjaoming for introducing the
make msgids
to me πIssues addressed
List the issues solved or partly solved by the PR
5514
5516