learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 306 forks source link

Missing translations for webpack bundles/*.js files #5517

Closed mrpau-eugene closed 6 years ago

mrpau-eugene commented 6 years ago

Summary

@rtibbles mentioned that the IGNORE_PATTERNS inside the Makefile ignores the source files for translation. We don't want this to happen.

Also, thanks @benjaoming for introducing the make msgids to me πŸ˜„

Issues addressed

List the issues solved or partly solved by the PR

5514

5516

codecov[bot] commented 6 years ago

Codecov Report

Merging #5517 into 0.17.x will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.17.x    #5517   +/-   ##
=======================================
  Coverage   62.77%   62.77%           
=======================================
  Files         117      117           
  Lines        6555     6555           
=======================================
  Hits         4115     4115           
  Misses       2440     2440

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 60b3a1a...3a26e38. Read the comment docs.

benjaoming commented 6 years ago

Oh #facepalm, well there's a pile of additional translations to be dealt with! Nicely spotted, I'll merge and upload the files to CrowdIn.

If we see additional translation activity, we can consider to inject the newly built translations files directly into existing content packs to avoid rebuilding them.

benjaoming commented 6 years ago

Btw. as the commit message said "Missing translations for *.js files" - this isn't true, it was a few .js messages in webpack bundles.

mrpau-eugene commented 6 years ago

Btw. as the commit message said "Missing translations for *.js files" - this isn't true, it was a few .js messages in webpack bundles.

Oh, yeah! You're right @benjaoming my bad.