search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 306 forks source link

Check HTTP Response for BDD tests #5532

Closed mrpau-eugene closed 6 years ago

mrpau-eugene commented 6 years ago

Summary

Just check the HTTP response if it is 200

TODO

Reviewer guidance

If you PR has a significant size, give the reviewer some helpful remarks

Issues addressed

List the issues solved or partly solved by the PR

codecov[bot] commented 6 years ago

Codecov Report

Merging #5532 into 0.17.x will decrease coverage by 0.12%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.17.x    #5532      +/-   ##
==========================================
- Coverage   62.78%   62.65%   -0.13%     
==========================================
  Files         117      117              
  Lines        6556     6555       -1     
==========================================
- Hits         4116     4107       -9     
- Misses       2440     2448       +8
Impacted Files Coverage Δ
kalite/facility/api_resources.py 93.6% <0%> (-1.64%) :arrow_down:
kalite/main/models.py 85.11% <0%> (-1.41%) :arrow_down:
kalite/coachreports/models.py 84.95% <0%> (-0.89%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b2b4a2...cc5203b. Read the comment docs.

benjaoming commented 6 years ago

Looks good! I'm not sure how many times, but this has definitely been a cause of head aches in the past :)