learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 306 forks source link

Move UI translations from content packs to repository #5537

Closed benjaoming closed 4 years ago

benjaoming commented 6 years ago

Summary

Taking over from #5524

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

Reviewer guidance

This should remove all translation files from content packs, instead fetching them from CrowdIn.

Issues addressed

5518

codecov[bot] commented 6 years ago

Codecov Report

Merging #5537 into 0.17.x will increase coverage by 0.11%. The diff coverage is 15.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.17.x    #5537      +/-   ##
==========================================
+ Coverage   62.59%   62.71%   +0.11%     
==========================================
  Files         117      117              
  Lines        6556     6550       -6     
==========================================
+ Hits         4104     4108       +4     
+ Misses       2452     2442      -10
Impacted Files Coverage Δ
kalite/i18n/management/commands/makemessages.py 95.83% <ø> (ø) :arrow_up:
...nagement/commands/setup_in_context_translations.py 0% <0%> (ø) :arrow_up:
...tributed/management/commands/contentpackchecker.py 0% <0%> (ø) :arrow_up:
kalite/i18n/base.py 55.15% <10.52%> (-0.7%) :arrow_down:
kalite/legacy/i18n_settings.py 86.36% <100%> (ø) :arrow_up:
...ributed/management/commands/retrievecontentpack.py 51.48% <11.11%> (+3.3%) :arrow_up:
kalite/project/settings/base.py 87.38% <0%> (-0.69%) :arrow_down:
kalite/distributed/views.py 78.65% <0%> (ø) :arrow_up:
kalite/facility/api_views.py 64% <0%> (+10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b2bf2e...c5667a9. Read the comment docs.

benjaoming commented 4 years ago

This refactor isn't possible to do in 0.17 and if anyone would wanna refactor this codebase, this would be a drop in the ocean :)