search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 306 forks source link

0.17.4b1 #5540

Closed benjaoming closed 6 years ago

benjaoming commented 6 years ago

WARNING! Merging this, merges and closes all PRs contained in this PR, and they may have a separate review process and amendments following. So don't merge this PR!! :)

New release, manually brewing the distributions:

Known issues

See release notes: http://ka-lite.readthedocs.io/en/develop/installguide/release_notes.html

Included PRs

Current 0.17.x branch

Installer links

PyPi

pip install ka-lite --pre

or

pip install ka-lite-static --pre  # bundled dependencies
codecov[bot] commented 6 years ago

Codecov Report

Merging #5540 into master will increase coverage by 1.89%. The diff coverage is 86.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5540      +/-   ##
==========================================
+ Coverage   62.76%   64.65%   +1.89%     
==========================================
  Files         117      117              
  Lines        6555     6609      +54     
==========================================
+ Hits         4114     4273     +159     
+ Misses       2441     2336     -105
Impacted Files Coverage Δ
kalite/updates/download_track.py 78.57% <ø> (+19.04%) :arrow_up:
kalite/topic_tools/content_models.py 78.08% <ø> (+2.8%) :arrow_up:
kalite/facility/api_resources.py 93.65% <100%> (-1.55%) :arrow_down:
kalite/updates/settings.py 100% <100%> (ø) :arrow_up:
...alite/updates/management/commands/videodownload.py 58.82% <60%> (+58.82%) :arrow_up:
kalite/updates/videos.py 85.93% <87.93%> (+32.6%) :arrow_up:
kalite/main/models.py 85.11% <0%> (-1.41%) :arrow_down:
kalite/main/api_views.py 89.47% <0%> (+1.75%) :arrow_up:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d34eaa6...0a46f41. Read the comment docs.

benjaoming commented 6 years ago

From testing this pre-release, it turns out that 1) Great, now retries are being made when downloads are broken, but 2) 500 error pages end up resulting in empty video files as mentioned in #5538

So essentially, this beta is a bit useless for its intended purpose.. closing again, no need to build Windows or Mac installers.