search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 306 forks source link

PEX test file build script + buildkite integration #5544

Closed benjaoming closed 6 years ago

benjaoming commented 6 years ago

Summary

To speed up testing a bit, an automated PEX build via Buildkite will be a good starting point:

Versions:

I think you can stick output of git describe in the file name. We don't have the same clever automatic dev versioning in KA Lite as Kolibri, but at least having a unique file name would be nice.

System information

Please specify the KA Lite version you were using and your operating system!

mrpau-eugene commented 6 years ago

@benjaoming I was wondering, would it be okay to use git describe?

I'm on the 0.17.x branch and executed git describe and then it gave me this v0.17.3-30-g86e1ea6e2.

Doesn't it make confusion since the KA-Lite Version is 0.17.4, but we will get something like ka-lite-static-v0.17.3-30-g86e1ea6e2.pex?

benjaoming commented 6 years ago

@mrpau-eugene garh, you are right, it's because we aren't tagging pre-releases

let's change the work flow, so pre-releases get merged into 0.17.x and only master serves as the "current stable". That way, we can tag and track our pre-releases in a linear way.

benjaoming commented 6 years ago

I can start doing tags for pre-releases once #5545 is finalized and a new pre-prelease is out..

benjaoming commented 6 years ago

@mrpau-eugene 0.17.x is now tagged, so if you apply git describe, you should get meaningful output now :)

mrpau-eugene commented 6 years ago

@benjaoming thanks!

benjaoming commented 6 years ago

Yay! Fixed in #5551 :) ( which was merged in #5552 )