Closed mrpau-eugene closed 6 years ago
@mrpau-eugene I found that the current Buildkite settings skip third-party PRs for security reasons.. which is actually a good idea.. however, just for now, let's switch it on so we can start using it and testing it some more.
Would you mind opening a new PR? Buildkite skips it despite that I close and re-open because it has seen the commit before methinks...
Summary
@benjaoming quite off from the instructions but I made it similar to how kolibri generates the pex and installers. I can make it as instructed (.buildkite/pex.sh) if this approach is not appropriate
TODO
If not all TODOs are marked, this PR is considered WIP (work in progress)
dist/ka-lite-static<version-info>.pex
Should we also upload the files to google cloud storage?
Reviewer guidance
If you PR has a significant size, give the reviewer some helpful remarks
Issues addressed
List the issues solved or partly solved by the PR
5544