search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
458 stars 305 forks source link

Build pex file and separate windows installer pipeline #5553

Closed mrpau-eugene closed 6 years ago

mrpau-eugene commented 6 years ago

check if it auto builds on buildkite

benjaoming commented 6 years ago

@mrpau-eugene nice find, have setup the Buildkite Github webhook now, so let's see if something happens..

mrpau-eugene commented 6 years ago

it seems that it still doesn't build automatically after closing and re-opening this pull request.

codecov[bot] commented 6 years ago

Codecov Report

Merging #5553 into 0.17.x will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.17.x    #5553   +/-   ##
=======================================
  Coverage   66.12%   66.12%           
=======================================
  Files         113      113           
  Lines        6504     6504           
=======================================
  Hits         4301     4301           
  Misses       2203     2203

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2649601...2628d5e. Read the comment docs.

benjaoming commented 6 years ago

@mrpau-eugene it should be alerted to push events and new pull requests AFAIK, so try either force-pushing an amended commit or try opening a new PR :)