learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
458 stars 305 forks source link

Build pex file and separate windows installer pipeline #5554

Closed mrpau-eugene closed 6 years ago

mrpau-eugene commented 6 years ago

test PR to see if it autobuilds on buildkite

codecov[bot] commented 6 years ago

Codecov Report

Merging #5554 into 0.17.x will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.17.x    #5554   +/-   ##
=======================================
  Coverage   66.12%   66.12%           
=======================================
  Files         113      113           
  Lines        6504     6504           
=======================================
  Hits         4301     4301           
  Misses       2203     2203

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2649601...df849af. Read the comment docs.

benjaoming commented 6 years ago

It does!! :tada: :smile:

benjaoming commented 6 years ago

@mrpau-eugene I think this looks very useful already, maybe if we can get a thumbs up from @radinamatic that the built artifacts (can be found on Buildkite ATM) are working, then we could merge.

@mrpau-eugene One very nice to have would be if we can have the artifacts available same way as for Kolibri (in the build status), so people don't have to login to see them on Buildkite. Do you know how to do this?

mrpau-eugene commented 6 years ago

One very nice to have would be if we can have the artifacts available same way as for Kolibri (in the build status), so people don't have to login to see them on Buildkite. Do you know how to do this?

@benjaoming I'm not quite sure how but I got some reference from kolibri repo. @rtibbles pointed me to this code on Kolibri https://github.com/learningequality/kolibri/blob/develop/.buildkite/upload_artifacts.py#L123 but I need a github access token that has the right permissions (not quite sure which permissions are needed) in order to have something like that.

benjaoming commented 6 years ago

Oh right, you mean this line? ACCESS_TOKEN = os.getenv("GITHUB_ACCESS_TOKEN")

benjaoming commented 6 years ago

@mrpau-eugene I have set both GOOGLE_APPLICATION_CREDENTIALS and GITHUB_ACCESS_TOKEN, in case they don't work, let me know by PM.

mrpau-eugene commented 6 years ago

@benjaoming yup! that's pretty much it. I also want to know how to build the debian installers manually. Can you give me some help?

mrpau-eugene commented 6 years ago

@benjaoming github status and being uploaded to google cloud is working now

benjaoming commented 6 years ago

GREAT WORK @mrpau-eugene :tada:

mrpau-eugene commented 6 years ago

@benjaoming Thanks 😄

Btw, we should change the access token as soon as LE Bot is ready..

benjaoming commented 6 years ago

@mrpau-eugene yes, did someone say they would create it btw? otherwise, I can do that today!

mrpau-eugene commented 6 years ago

@benjaoming I think it was @rtibbles who mentioned it that they were talking about creating an LE bot