Closed mrpau-eugene closed 6 years ago
Merging #5554 into 0.17.x will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## 0.17.x #5554 +/- ##
=======================================
Coverage 66.12% 66.12%
=======================================
Files 113 113
Lines 6504 6504
=======================================
Hits 4301 4301
Misses 2203 2203
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2649601...df849af. Read the comment docs.
It does!! :tada: :smile:
@mrpau-eugene I think this looks very useful already, maybe if we can get a thumbs up from @radinamatic that the built artifacts (can be found on Buildkite ATM) are working, then we could merge.
@mrpau-eugene One very nice to have would be if we can have the artifacts available same way as for Kolibri (in the build status), so people don't have to login to see them on Buildkite. Do you know how to do this?
One very nice to have would be if we can have the artifacts available same way as for Kolibri (in the build status), so people don't have to login to see them on Buildkite. Do you know how to do this?
@benjaoming I'm not quite sure how but I got some reference from kolibri repo. @rtibbles pointed me to this code on Kolibri https://github.com/learningequality/kolibri/blob/develop/.buildkite/upload_artifacts.py#L123 but I need a github access token that has the right permissions (not quite sure which permissions are needed) in order to have something like that.
Oh right, you mean this line? ACCESS_TOKEN = os.getenv("GITHUB_ACCESS_TOKEN")
@mrpau-eugene I have set both GOOGLE_APPLICATION_CREDENTIALS
and GITHUB_ACCESS_TOKEN
, in case they don't work, let me know by PM.
@benjaoming yup! that's pretty much it. I also want to know how to build the debian installers manually. Can you give me some help?
@benjaoming github status and being uploaded to google cloud is working now
GREAT WORK @mrpau-eugene :tada:
@benjaoming Thanks 😄
Btw, we should change the access token as soon as LE Bot is ready..
@mrpau-eugene yes, did someone say they would create it btw? otherwise, I can do that today!
@benjaoming I think it was @rtibbles who mentioned it that they were talking about creating an LE bot
test PR to see if it autobuilds on buildkite