search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
458 stars 305 forks source link

Autobuilt pex filename wrong #5558

Closed benjaoming closed 6 years ago

benjaoming commented 6 years ago

Summary

Briefly describe what this is about image

System information

Please specify the KA Lite version you were using and your operating system!

benjaoming commented 6 years ago

This is again an issue with using git describe, it doesn't understand tags and branches as one might intuitively expect.

Tagging master is necessary because of the way that Github tracks releases on the master branch.

Would suggest to use the current KA Lite version and add a commit hash to it for uniqueness.

benjaoming commented 6 years ago

Fixed!