search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 306 forks source link

Bump ipcfg to 0.13 and use for Windows also #5563

Closed benjaoming closed 6 years ago

benjaoming commented 6 years ago

Summary

Improves detection of local IP.

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

Reviewer guidance

n/a

Issues addressed

5498

codecov[bot] commented 6 years ago

Codecov Report

Merging #5563 into develop will increase coverage by 0.74%. The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5563      +/-   ##
===========================================
+ Coverage     65.4%   66.15%   +0.74%     
===========================================
  Files          113      113              
  Lines         6504     6512       +8     
===========================================
+ Hits          4254     4308      +54     
+ Misses        2250     2204      -46
Impacted Files Coverage Δ
kalite/distributed/views.py 78.65% <100%> (ø) :arrow_up:
kalite/cli.py 51.62% <90%> (+0.67%) :arrow_up:
kalite/topic_tools/content_models.py 77.8% <0%> (+0.56%) :arrow_up:
kalite/topic_tools/annotate.py 80.3% <0%> (+12.12%) :arrow_up:
kalite/topic_tools/base.py 57.57% <0%> (+12.12%) :arrow_up:
kalite/updates/videos.py 88.73% <0%> (+15.49%) :arrow_up:
...alite/updates/management/commands/videodownload.py 74.56% <0%> (+19.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74b9585...3ea066f. Read the comment docs.