learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 306 forks source link

Use software version and a commit hash in pex filename #5564

Closed benjaoming closed 6 years ago

benjaoming commented 6 years ago

Summary

Uses kalite --version for the filename

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

Reviewer guidance

n/a

Issues addressed

https://github.com/learningequality/ka-lite/issues/5558

codecov[bot] commented 6 years ago

Codecov Report

Merging #5564 into develop will increase coverage by 19.84%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5564       +/-   ##
============================================
+ Coverage    46.31%   66.15%   +19.84%     
============================================
  Files          113      113               
  Lines         6512     6512               
============================================
+ Hits          3016     4308     +1292     
+ Misses        3496     2204     -1292
Impacted Files Coverage Δ
kalite/shared/api_auth/auth.py 41.53% <0%> (+0.76%) :arrow_up:
kalite/topic_tools/content_recommendation.py 84.52% <0%> (+0.79%) :arrow_up:
kalite/distributed/middleware.py 57.77% <0%> (+2.22%) :arrow_up:
kalite/coachreports/api_views.py 93.07% <0%> (+2.3%) :arrow_up:
kalite/facility/api_resources.py 93.79% <0%> (+3.1%) :arrow_up:
kalite/shared/decorators/auth.py 42.7% <0%> (+3.12%) :arrow_up:
kalite/contentload/api_views.py 29.5% <0%> (+3.27%) :arrow_up:
kalite/main/api_views.py 89.47% <0%> (+3.5%) :arrow_up:
kalite/main/api_resources.py 85.45% <0%> (+7.27%) :arrow_up:
kalite/facility/models.py 74.56% <0%> (+10.4%) :arrow_up:
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5b0f30...aebcf43. Read the comment docs.

benjaoming commented 6 years ago

The .pex from Buildkite in this PR is now called ka-lite-static0.18.0dev0-aebcf43ecf082cccd1b1ec066c7ca2c91375bc5c.pex, I'm okay with that :)