search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 306 forks source link

Fix wrong remote_size when annotating content #5565

Closed mrpau-eugene closed 4 years ago

mrpau-eugene commented 6 years ago

Summary

Take this for example:

After a successful scan, some of the Topics' remote_size becomes 0

screen shot 2018-01-30 at 1 24 42 pm

Therefore, when ticking the Math topic, it might look something like this: image

@benjaoming this was the one I found. Could you test this one?

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

Reviewer guidance

If you PR has a significant size, give the reviewer some helpful remarks

Issues addressed

List the issues solved or partly solved by the PR

benjaoming commented 4 years ago

This change didn't make sense, the logic expression was a "not ((a and b) or b)" which would be the same as just saying "not b".