learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity

https://learningequality.org/ka-lite/

Other

458 stars 305 forks source link

Always raise an error when importing from django.contrib.gis #5592

Closed benjaoming closed 5 years ago

benjaoming commented 5 years ago

Summary

This is an attempt to address the issue in https://github.com/iiab/iiab/issues/1382

There are version strings of libgeos system libraries that seem to make the loading crash.

TODO

[ ] Has documentation been written/updated?
[ ] Have you written release notes for the upcoming release?

Reviewer guidance

Let's assume that our tests would break, since this is about load-time issues.. not request/response related.

Issues addressed

https://github.com/iiab/iiab/issues/1382

codecov[bot] commented 5 years ago

Codecov Report

Merging #5592 into 0.17.x will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           0.17.x    #5592   +/-   ##
=======================================
  Coverage   66.05%   66.05%           
=======================================
  Files         113      113           
  Lines        6508     6508           
=======================================
  Hits         4299     4299           
  Misses       2209     2209

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5a3462...768629a. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #5592 into 0.17.x will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           0.17.x    #5592   +/-   ##
=======================================
  Coverage   66.05%   66.05%           
=======================================
  Files         113      113           
  Lines        6508     6508           
=======================================
  Hits         4299     4299           
  Misses       2209     2209

Impacted Files	Coverage Δ
kalite/distributed/views.py	`78.65% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5a3462...56bee65. Read the comment docs.

benjaoming commented 5 years ago

Ay, just ran into this on a normal 18.04