search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 306 forks source link

central-develop into 0.17.x #5595

Closed benjaoming closed 4 years ago

benjaoming commented 4 years ago

Summary

These changes are necessary to align the current central server with the current KA Lite release. Some changes to the control_panel app are necessary to keep data export working for many of the larger deployments. More specifically, they have to generate CSV exports in an async environment, which will be done following a change to the central server itself to just use this upcoming 0.17.6.dev release.

This PR flags a few problematic changes that we need to fix for things to work in both the distributed and the central server environments

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

Reviewer guidance

I would definitely not mind a quick look from @jamalex and @rtibbles if you happen to have time.

Issues addressed

benjaoming commented 4 years ago

Having tested this to the point of registration and by introspecting settings, it seems that the securesync client connects correctly. I had another issues fixed in #5597 - but this should be fine.