learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
458 stars 305 forks source link

Summarized remote_size was wrong and often 0 #5598

Closed benjaoming closed 5 years ago

benjaoming commented 5 years ago

Summary

Going to try out this fix, based off #5565 -- if it doesn't work, I will let it go, since it's a very complex place in the codebase.

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

Reviewer guidance

No review expected

Issues addressed

Not sure, but this has been a long-standing problem.

benjaoming commented 5 years ago

No, the previous summary expression was correct as remote_size is used to store size of the remaining unfetched children.