search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
456 stars 306 forks source link

Improve feedback from AssertionError #5617

Closed benjaoming closed 4 years ago

benjaoming commented 4 years ago

Summary

These tests rely on Session data, which may be prone to concurrent access.

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

Reviewer guidance

If you PR has a significant size, give the reviewer some helpful remarks

Issues addressed

List the issues solved or partly solved by the PR

benjaoming commented 4 years ago

This is related to the following types of errors:

FAIL: test_delete_org (centralserver.central.tests.browser_tests.OrganizationDeletionTestCase)

Delete an empty org

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/fle-internal/ka-lite-central/centralserver/central/tests/browser_tests.py", line 307, in test_delete_org

    self.browser_check_django_message(message_type="success", contains="successfully deleted")

  File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/kalite/testing/mixins/browser_mixins.py", line 130, in browser_check_django_message

    self.assertEqual(num_messages, len(messages), msg)

AssertionError: 1 != 2 : Make sure there are 1 message(s), type='success'.

======================================================================

FAIL: test_issue_697_part2 (centralserver.central.tests.browser_tests.OrganizationDeletionTestCase)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/fle-internal/ka-lite-central/centralserver/central/tests/browser_tests.py", line 337, in test_issue_697_part2

    self.test_delete_org()

  File "/home/travis/build/fle-internal/ka-lite-central/centralserver/central/tests/browser_tests.py", line 307, in test_delete_org

    self.browser_check_django_message(message_type="success", contains="successfully deleted")

  File "/home/travis/virtualenv/python2.7.15/lib/python2.7/site-packages/kalite/testing/mixins/browser_mixins.py", line 130, in browser_check_django_message

    self.assertEqual(num_messages, len(messages), msg)

AssertionError: 1 != 2 : Make sure there are 1 message(s), type='success'.