search

learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
458 stars 305 forks source link

Ad blocker note #5628

Open benjaoming opened 4 years ago

benjaoming commented 4 years ago

Summary

Fixes #5619

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

Reviewer guidance

If you PR has a significant size, give the reviewer some helpful remarks

Issues addressed

List the issues solved or partly solved by the PR

codecov[bot] commented 4 years ago

Codecov Report

Merging #5628 into 0.17.x will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           0.17.x    #5628   +/-   ##
=======================================
  Coverage   46.34%   46.34%           
=======================================
  Files         113      113           
  Lines        6514     6514           
=======================================
  Hits         3019     3019           
  Misses       3495     3495

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e85c24b...986c31e. Read the comment docs.

benjaoming commented 4 years ago

CC: @jamalex @aronasorman

This is ready to go in and be part of the next release. As clarified in a Notion project page, KA Lite will work fine if the Central Server is taken down. These string updates were IMO the closest I could come to a meaningful change.