learningequality / ka-lite

KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity
https://learningequality.org/ka-lite/
Other
458 stars 305 forks source link

CodeCov security blooper #5631

Open benjaoming opened 3 years ago

benjaoming commented 3 years ago

Summary

We should always use package managers. I suppose I might have written this code. Moreover, this Circle CI integration might not even work anymore, I think they have thrown out their 1.0 API.

But just to be sure :)

See: https://about.codecov.io/security-update

TODO

If not all TODOs are marked, this PR is considered WIP (work in progress)

Reviewer guidance

This is mainly just to get rid of a mal-practice so it doesn't spread, nothing more. It doesn't even matter if the CI still works. Just remove this horrible line of code and we're good.

This repo isn't affected since the attack was on Jan 31 and no one has been doing builds since.

Issues addressed

n/a

CC: @aronasorman @rtibbles please note the attack and if you are using this in other repos