search

learningequality / kolibri-design-system

Kolibri Design System
https://design-system.learningequality.org
27 stars 65 forks source link

Update glossary with latest export from Crowdin #274

Open indirectlylit opened 2 years ago

indirectlylit commented 2 years ago

Product

KDS

Expected behavior

The glossary page should be updated with the latest content from Crowdin after 0.15 is close to finished being translated.

Additional information

refs:

If I remember correctly, the .tbx file can be exported from Crowdin. We may also have had some discussion with @radinamatic about migrating away from the .tbx format in KDS, but I don't recall the details.

radinamatic commented 2 years ago

We are using to CSV/XLSX instead of the TBX format for the glossary updates/translation on Crowdin, as I mentioned some time ago.

Since the glossary on Crowdin seems to be the most efficient choice as the source-of-truth (easier to maintain and add corrections when needed), there is no reason to change the existing functions to update glossary on KDS using the TBX file from Crowdin, if the import is performed manually, and not set up as some sort of automatic periodic update.

indirectlylit commented 2 years ago

Okay so if I'm understand correctly: as long as glossary updates are one-directional from crowdin -> KDS, the current TBX format is acceptable?

radinamatic commented 2 years ago

Apologies for the delay!

Yes, one-directional update Crowdin -> KDS, using the current TBX format should work fine. Can you share where the function use is documented, as it probably makes the most sense for me to perform this update whenever there is a new version on Crowdin?

indirectlylit commented 2 years ago

Good question – it does not appear to be documented, and I'd forgotten the origins of this work.

Here's the original update (with discussion) when we added the glossary to the Kolibri code-base:

https://github.com/learningequality/kolibri/pull/6019

It was subsequently copied to KDS (with additional discussion) here:

https://github.com/learningequality/kolibri-design-system/pull/134

Would you mind reading through the threads in those PR and then we can follow up and decide on next steps? I think this probably warrants a conversation.

indirectlylit commented 2 years ago

in the meantime, opened the PRs referenced above --^

radinamatic commented 6 months ago

Going back to @radinamatic 's top of the pile!