search

learningequality / kolibri-design-system

Kolibri Design System
https://design-system.learningequality.org
28 stars 69 forks source link

KModal forms are not fully keyboard accessible because focus is not trapped #329

Open jonboiser opened 4 years ago

jonboiser commented 4 years ago

Observed behavior

Similar to learningequality/kolibri#6043, when (shift)-tabbing through a KModal form, keyboard focus will be lost when going out of bounds:

  1. If at first focusable element, Shift-Tab will take you to top of the KModal element outside of the form (but tabbing once will bring you back to the form)
  2. At the last focusable element, Tab will take you to the browser chrome (in Chrome, at least).

Expected behavior

A more convenient keyboard navigation, similar to the fix to learningequality/kolibri#6043 but within KMOdal.

User-facing consequences

…

Errors and logs

…

Steps to reproduce

…

Context

…

pcenov commented 2 years ago

@radinamatic this one is still valid in 0.15.1

marcellamaki commented 2 years ago

Transferred from kolibri to KDS so update is made in KModal

nucleogenesis commented 2 years ago

I will review this as I ran into it recently -- may solve with improved documentation or updating KModal