search

learningequality / kolibri-design-system

Kolibri Design System
https://design-system.learningequality.org
30 stars 73 forks source link

Remove theme-dependent SCSS variables: Remove variables within KDS files that rely on theming SCSS variables #617

Open LianaHarris360 opened 7 months ago

LianaHarris360 commented 7 months ago

Product

Kolibri-design-system: Internal

Current behavior

In the file lib/keen/styles/variables.scss, defined variables rely other theming variables and should be removed. For example:

 // Secondary text color
$secondary-text-color: #666666!default;

$ui-input-label-color: $secondary-text-color !default;

(Optional) The Value Add

Theme-dependent SCSS variables have the potential to break our theming. Overall, this may only pose a concern within our vendored Keen components that are integrated with KDS.

This could potentially be part of a larger initiative to fully integrate or remove our vendored Keen components altogether.

LianaHarris360 commented 1 month ago

Related comment addressing this issue: https://github.com/learningequality/kolibri-design-system/pull/616#discussion_r1562985643