learningequality / kolibri-design-system

Kolibri Design System
https://design-system.learningequality.org
27 stars 65 forks source link

[GSOC] Github workflow and PR checks for visual differences #683

Closed bjester closed 1 week ago

bjester commented 1 month ago

Product

KDS itself

Desired behavior

As an engineer reviewing KDS pull requests, I would like to see what visual differences resulted from the PR's changes. A visual testing GH workflow should be created that:

The existing unit testing workflow should remain unchanged.

Current behavior

No such workflow or functionality currently exists

(Optional) The Value Add

This will help contributors making changes to KDS, and reviewers of those changes, be more confident that there aren't visual regressions caused by the changes.

(Optional) Possible Tradeoffs

It adds another step in the process of PR reviews, but a step that would otherwise be a manual process. Insufficient visual test coverage could also expose weaknesses in the process.

KshitijThareja commented 1 month ago

Thanks @bjester for creating the issue. Will have the PR up soon :)

AlexVelezLl commented 1 week ago

Closed by #686