Open MisRob opened 1 month ago
i've already finished commenting the deprecated drop shadows , can you assign this to me, so i can PR my changes?
Thanks @lokesh-sagi125. I'll assign you. Just a note it's better to get assigned first in case some clarification is needed, so please always message us and wait for assignment.
Would you mind splitting https://github.com/learningequality/kolibri-design-system/pull/734 into two pull requests? One that resolves https://github.com/learningequality/kolibri-design-system/issues/724 and another that resolves this issue.
These are deliberately two issues because https://github.com/learningequality/kolibri-design-system/issues/724 can be merged soon, whereas for the other one we will be waiting until https://github.com/learningequality/kolibri/issues/12552, otherwise it'd break many places in Kolibri. We will then review both pull requests.
🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.
Blocked by
Summary
For both internal KDS components styling and external use by non-KDS components in our products, according to the updated guidelines in the "Elevation and shadow > Drop shadows" documentation section, we only need to keep
%dropshadow-1dp
,%dropshadow-2dp
, and%dropshadow-6dp
in the definitions.scss:https://github.com/learningequality/kolibri-design-system/blob/0cbdf57d24690cb6c23618ba700118a831cd9ffc/lib/styles/definitions.scss#L59-L157
All other
%dropshadow-...
should not be available for use.Guidance