learningequality / kolibri-design-system

Kolibri Design System
https://design-system.learningequality.org
28 stars 66 forks source link

Add KFocusTrap and use it in KModal #746

Open MisRob opened 3 weeks ago

MisRob commented 3 weeks ago

šŸŒ± Are you new to the codebase? Welcome! Please see the contributing guidelines.

Blocks

Summary

This issue has two related goals

Guidance

(1) Create KFocusTrap

Copy FocusTrap from Kolibri to this repository and name it as KFocusTrap. Follow the guidance for creating a new component.

(2) Wrap the content of KModal in KFocusTrap

// KModal.vue
<template>
  <KFocusTrap>
    <component :is="wrapper" ...>
    ...

(3) Check that the focus trapping works as expected

on the the playground page.

(4) Add a new documentation page for KFocusTrap

The Value Add

Improves accessibility of modals.

Acceptance criteria

lokesh-sagi125 commented 2 weeks ago

hey @MisRob can you assign this to me?

MisRob commented 2 weeks ago

Hey @lokesh-sagi125, assigning, thank you for volunteering

lokesh-sagi125 commented 2 weeks ago

hey @MisRob is there any chat server for LE like discord or is it just github?

lokesh-sagi125 commented 2 weeks ago

hey @akolson @MisRob i keep getting this particular linting issue even though i added the blank lines. ,couldn't find the solution in the documentation , what should i do to fix this?.

Screenshot 2024-09-02 at 10 13 03ā€ÆPM
akolson commented 2 weeks ago

Its most likely the line spacing before the Githubissues.

  • Githubissues is a development platform for aggregating issues.