search

learningequality / kolibri-installer-android

Android wrapper for Kolibri.
MIT License
26 stars 22 forks source link

Back button returns to the loading page #146

Closed rtibbles closed 1 year ago

rtibbles commented 1 year ago

Observed behavior

This is a regression caused by dropped commits in our P4A fork. We should not include the loading page in the browser history.

Expected behavior

Back should not take you to the loading screen.

Additionally, exiting the app is arduous, as it is required to get to the first page in the history before the 'double tap to exit' behaviour is enabled. This should always be available.

rtibbles commented 1 year ago

This appears to have already been fixed by migrating to not using a static file for the loading screen, but by setting it as data in the webview.

Our lack of an exit button actually seems in accordance with other Android apps, so I think we can skip the second part of this as well.