learningequality / kolibri-installer-android

Android wrapper for Kolibri.
MIT License
26 stars 22 forks source link

Revert "Merge pull request #175 from learningequality/notifications" #176

Closed bjester closed 10 months ago

bjester commented 10 months ago

Reverts the PR https://github.com/learningequality/kolibri-installer-android/pull/175

The following errors were observed:

11-23 19:59:59.520 13177 13203 E WM-WorkerWrapper: java.util.concurrent.ExecutionException: java.util.concurrent.ExecutionException: java.util.concurrent.ExecutionException: java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.Integer.intValue()' on a null object reference
11-23 19:59:59.520 13177 13203 E WM-WorkerWrapper:  at androidx.work.impl.utils.futures.AbstractFuture.getDoneValue(AbstractFuture.java:516)
11-23 19:59:59.520 13177 13203 E WM-WorkerWrapper:  at androidx.work.impl.utils.futures.AbstractFuture.get(AbstractFuture.java:475)
11-23 19:59:59.520 13177 13203 E WM-WorkerWrapper:  at androidx.work.impl.utils.SerialExecutor$Task.run(SerialExecutor.java:91)
11-23 19:59:59.520 13177 13203 E WM-WorkerWrapper:  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
11-23 19:59:59.520 13177 13203 E WM-WorkerWrapper:  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)

And

11-24 16:07:51.269  1435  5625 W ActivityManager: Scheduling restart of crashed service org.learningequality.Kolibri/.TaskworkerWorkerService in 1000ms for connection
11-24 16:07:51.271 19976 20022 E WM-WorkerWrapper: Work [ id=1032c3f4-c0d3-47ac-8e12-7243112e77eb, tags={ kolibri_job_type:kolibri.core.auth.tasks.soud_sync_processing, kolibri_task_id:50, org.learningequality.Kolibri.TaskworkerWorker } ] failed because it threw an exception/error
11-24 16:07:51.271 19976 20022 E WM-WorkerWrapper: java.util.concurrent.ExecutionException: java.lang.RuntimeException: Binder died
11-24 16:07:51.271 19976 20022 E WM-WorkerWrapper:      at androidx.work.impl.utils.futures.AbstractFuture.getDoneValue(AbstractFuture.java:516)
11-24 16:07:51.271 19976 20022 E WM-WorkerWrapper:      at androidx.work.impl.utils.futures.AbstractFuture.get(AbstractFuture.java:475)
11-24 16:07:51.271 19976 20022 E WM-WorkerWrapper:      at androidx.work.impl.utils.SerialExecutor$Task.run(SerialExecutor.java:91)
11-24 16:07:51.271 19976 20022 E WM-WorkerWrapper:      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
11-24 16:07:51.271 19976 20022 E WM-WorkerWrapper:      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
11-24 16:07:51.273 19976 20022 I WM-WorkerWrapper: Worker result FAILURE for Work [ id=1032c3f4-c0d3-47ac-8e12-7243112e77eb, tags={ kolibri_job_type:kolibri.core.auth.tasks.soud_sync_processing, kolibri_task_id:50, org.learningequality.Kolibri.TaskworkerWorker } ]
pcenov commented 10 months ago

Hi @bjester - I can confirm that this version of the app is working better as now both the Android 7.1.1 device and the Android 13 one are syncing correctly for about 2 hours before stopping with no option to resume the syncing (tried restarting the server and the apps, restarting the devices). With the previous build when setting up the Android 7.1.1 device as a LOD I had to always manually enter the URL of the server as it was not being displayed automatically in the setup wizard and then the device would not sync after the initial download of the resources. Now this is fixed. Here are the logs from two rounds of testing using 2 Android LODs, 1 Ubuntu LOD and an Ubuntu server: Test 1.zip Test 2.zip

radinamatic commented 10 months ago

Very similar experience on my side: much better than in beta9, but glitches still present.

The first device (Mg51 phone) was syncing fine for the few hours yesterday, but eventually stopped sometimes overnight. App restart and phone reboot did not manage to resume the syncing, but restarting the server on Windows 11 VM did do the trick. Then it continued syncing for about 4 hours, pausing occasionally (meaning that I could see Synced N minutes ago instead of ...N seconds ago on the coach side) when I left the app in the background or the screen turned off, but would eventually resume when I picked up the device and interacted with the app again. Alas, that state only lasted 3-4 hours after which it stopped syncing completely and not even a second server restart managed to make it resume.

Android12-MotoG51-AndroidStudio4.zip

This morning I also added a tablet to the mix and this one has been syncing steadily for almost 8-9 hours straight, even though the app has been mostly in the background and/or idle during that time... Go figure 🤷🏽‍♀️

Android11-TabA7-AndroidStudio2.zip

radinamatic commented 10 months ago

And about 20 minutes ago the tablet also stopped syncing 😞

Android11-TabA7-AndroidStudio3.log

bjester commented 10 months ago

Closing. https://github.com/learningequality/kolibri-installer-android/pull/177 supersedes this