search

learningequality / kolibri-installer-android

Android wrapper for Kolibri.
MIT License
26 stars 22 forks source link

check env var to determine the apk path #40

Closed lyw07 closed 4 years ago

lyw07 commented 4 years ago

This PR is to fix our current android build failure. The issue is that apk file got copied to /home/kivy instead of /home/kivy/dist, and I assume this is when P4A_RELEASE_KEYSTORE is set to /home/kivy/ instead of /home/kivy/dev.keystore

DXCanas commented 4 years ago

I haven't gotten a chance to test locally yet, but my first questions is why it took so long for this to manifest? Has p4a changed the output directory from dist @kollivier

indirectlylit commented 4 years ago

ref: https://github.com/learningequality/kolibri/issues/6420

kollivier commented 4 years ago

The reason is that Docker has been using cached everything for a very long time, and so when the cache was cleared the other day, it finally went about updating all the dependencies. From what I can tell, it applied some updates that are over several months old. So it could be a p4a update, or some other reason. It definitely is a change from previous behavior, so I want to get to the bottom of what exactly happened to figure out if we need to be pinning a dependency, etc.

There were also definitely a couple pyeverywhere bugs I introduced while refactoring. Because I can't test locally on Mac with p4a anymore due to dependency build errors, I was relying on the Android build to error out if I made a mistake. Apologies for that. I need to just bite the bullet and set up CI for pyeverywhere that builds a sample project to ensure the change is kosher!

DXCanas commented 4 years ago

Turns out it was a p4a change, and I've resolved it in #43

Thanks for all the work here @lyw07, you definitely nailed the symptom

lyw07 commented 4 years ago

🎉🎉🎉

indirectlylit commented 4 years ago

what's p4a?

indirectlylit commented 4 years ago

oh - python for android