learningequality / kolibri-installer-debian

Kolibri installer source for Debian
MIT License
1 stars 8 forks source link

Simple utility to launch Kolibri URL #81

Open benjaoming opened 5 years ago

benjaoming commented 5 years ago

When installing Kolibri, it would perhaps make sense that we add an application launcher, such that people can continue after installing without too much hassle.

Example:

Have an icon in the default desktop environments's application launcher that says "Kolibri" and launches Firefox on http://127.0.0.1:8080

Solution:

It is quite possible that using service kolibri start and service kolibri status, together with xdg-open can launch kolibri at its currently served location.

We should not add new dependencies because of this, as the Desktop launcher can exist despite there being now XDG or browser.. in this case, a user won't see the launcher anyways.

Scope:

This issue does NOT propose to create a new UI or open up a discussion about a notification area, control panel or similar.

If this requires new UI to be written, we should not do this.

jredrejo commented 5 years ago

If I understand this correctly, it would be for the cases where kolibri is not installed to start on boot, right? in that case I see a couple of possible conflict points:

  1. Why using service kolibr start and stop? when being in the userland, only kolibri startis needed , so we don't have to deal with sudo or other possible problems to start a service from an user account
  2. Being Linux a multiuser system, we should find a way to show a dialog warning if the user tries to start kolibri and it can't because the port is open. That could happen in systems using LTSP or similar solutions. Normal desktop users should not have this problem.

@benjaoming what do you think about these questions?

benjaoming commented 5 years ago

If I understand this correctly, it would be for the cases where kolibri is not installed to start on boot, right?

Not exactly: It's also to ensure that users don't end up installing Kolibri and being like "now what?". Meaning that they expect a program to appear, not understanding that they should open up a browser on http://<ip>:<port>.

I agree that multi-user and sudo stuff poses a clever solution, perhaps a conditional statement that understands the system service's Kolibri username.

If we can solve this for a simple launcher, we have also solved it for any subsequent control panel UI.

indirectlylit commented 5 years ago

It's also to ensure that users don't end up installing Kolibri and being like "now what?". Meaning that they expect a program to appear, not understanding that they should open up a browser on http://<ip>:<port>.

FYI the current direction we're moving is to distinguish multi-user environments from single-user desktop applications. See the current work on mac here:

We'll eventually extend this to other operating systems. I'd prefer that we spend time working in that direction and would propose we close this particular feature as "won't fix".

benjaoming commented 5 years ago

@indirectlylit re-iterating what I wrote right above your comment:

If we can solve this for a simple launcher, we have also solved it for any subsequent control panel UI.

"Any subsequent" also includes whatever application container that launches Kolibri in a single user environment.