search

learningequality / kolibri-installer-windows

Repository for Kolibri windows installer
MIT License
5 stars 12 forks source link

Cannot build the projects after checkout and following the instructions in README. #169

Open cpauya opened 4 years ago

cpauya commented 4 years ago

Observed behavior

I cannot build these projects after checkout of the repo and following the build steps to Run the project using Inno Setup for development.

  1. Visual Studio project (Kolibri GUI app): \src\gui-source\Kolibri.sln
  2. Inno Setup project (Kolibri installer): \src\installer-source\KolibriSetupScript.iss

Here's a list of the issues. See below for screenshots.

  1. Visual Studio 2015 Community Edition - Issue: Install Windows XP Support for C++ -- Windows 7.1 SDK for targeting Windows XP.
  2. InnoSetup - Issue: build error, some settings are needed in the [Setup] section AppVerName, etc
  3. Inno Setup - Issue: Language files are missing -- Greek.isl, Nepali.isl, Vietnamese.isl, Marathi.islu, Korean.isl, Hindi.islu, Bulgarian.isl, Bengali.islu
  4. Wheel file is missing at the \src\installer-source\kolibri*.whl

Issue: Install Windows XP Support for C++ -- Windows 7.1 SDK for targeting Windows XP.

Screen Shot 2020-05-13 at 2 56 44 PM

Issue: Language files are missing -- Greek.isl, Nepali.isl, Vietnamese.isl, Marathi.islu, Korean.isl, Hindi.islu, Bulgarian.isl, Bengali.islu

Screen Shot 2020-05-13 at 5 49 51 PM

Expected behavior

The repo projects should build after following the instructions in the README.

Possible Solution/s

  1. For the "missing languages" issue, copy the missing files from the \src\inno-compiler\Languages\ folder to the C:\Program Files (x86)\Inno Setup 6\Languages\ folder. Note: needs admin permissions
  2. If no repo changes are needed, maybe update the README file to address the above issues.

User-facing consequences

This hampers development and might discourage outside contributions.

Errors and logs

n/a

Steps to reproduce

  1. Checkout the repo.
  2. Follow the steps to Run the project using Inno Setup for development
  3. Notice the issues that are shown.

Context

indirectlylit commented 4 years ago

thanks!

as a stop-gap, I've added a quick note to the readme referencing this issue: 3aa0c603d18442e0c6e989bc6b01a440c827d979