learningequality / kolibri-instant-schools-plugin

4 stars 10 forks source link

don't GET profiles list, POST for it to avoid plaintext passwords #186

Closed nucleogenesis closed 2 years ago

nucleogenesis commented 2 years ago

NCC Group found that we were passing the user's password as plaintext to the endpoint that listed all profiles for the given phone number.

This PR changes the list endpoint of the PhoneAccountProfileViewset to wrap with the @action decorator that expects a POST and updates the code to use POST data rather than the query string.