Closed jredrejo closed 5 months ago
Finished ILO Start and Improve your business channel, available at https://studio.learningequality.org/en/channels/4752ba7fbade5ad88e06eb3bc79dd88c/ , token to test it in kolibri tijom-zonab
@rtibbles code to review at https://github.com/learningequality/sushi-chef-ilo-siyb
Tested the channel locally in all browsers on both Ubuntu 20.04 and Windows 10, HTML5 apps and PDF files all open without issues! ππ½ π
I again downloaded the PDF files and opened in Acrobat Pro to see if they can be easily remediated to become at least partially accessible, but no dice: formatting is clearly meant for documents to be printed on paper, with scrambled semantic structure that would require way too much time to make accessible. Many documents are complex tables which are particularly thorny π
I have 2 questions and 1 request for change:
.pdf
( $filename \ne title$ π )Tested the channel locally in all browsers on both Ubuntu 20.04 and Windows 10, HTML5 apps and PDF files all open without issues! ππ½ π
Thanks for the review, this is unvaluable
I again downloaded the PDF files and opened in Acrobat Pro to see if they can be easily remediated to become at least partially accessible, but no dice: formatting is clearly meant for documents to be printed on paper, with scrambled semantic structure that would require way too much time to make accessible. Many documents are complex tables which are particularly thorny π
if there is any automated tool that can be passed over them to improve them, I'll do it gladly. I'm all ears-
I have 2 questions and 1 request for change:
- Source for Start your business is here, but I was not able to find the link for the Improve your business. Could you share that link?
No, because they didn't provide it in a link form, but as a list of zipped files in scorm format that I uploaded to Google drive. . I know @revanthvle has been exchanging emails to find the license that applies to this courses, but they're not available in the form of a web site as far as we know.
- I'm not seeing the Final self-assessment resource in the Start your business... π€ Was it an oversight or a conscious decision to omit it?
Oh, no, it's just they weren't in the scorm files they passed. I'll check if it can be scrapped from the web, but being a SPA that's rendered on the fly I'm not confident the tests will be easily retrieved.
- I know a lot of effort was invested into cheffing these, but we could improve the titles of the PDF resources by: a. Not using the acronyms SYB, IYB, GYB, but expand them fully to Start your business, Improve your business, and Generate your business idea (for clarity, especially if/when the resource is saved locally). b. Removing the
Sure, I'll do it, I didn't notice that. Being so very few pdf files I can prepare a list of the titles manually if there's not way to extract a right title from the pdf content.
if there is any automated tool that can be passed over them to improve them, I'll do it gladly.
Don't I wish... π (me and every other accessibility professional)
Oh, no, it's just they weren't in the scorm files they passed. I'll check if it can be scrapped from the web, but being a SPA that's rendered on the fly I'm not confident the tests will be easily retrieved.
Understood, I thought you did scrape all from the web π
I can prepare a list of the titles manually if there's not way to extract a right title from the pdf content.
If the files had been tagged and accessible, it would be much easier to extract proper title, but no dice in this case. You can try to set up some substitution filters, or prepare the list of titles manually as you say, since there are not that many files.
I can prepare a list of the titles manually if there's not way to extract a right title from the pdf content.
If the files had been tagged and accessible, it would be much easier to extract proper title, but no dice in this case. You can try to set up some substitution filters, or prepare the list of titles manually as you say, since there are not that many files.
Done
I am not sure the level of granularity I should be looking at this but looks great! Some small improvements:
- Can we change the channel name to "Start and Improve Your Business" (with that capitalization) and do we need the "ILO" at the beginning?
Done
In the Start your business folder
- There are two PDFs at the end that I suggest renaming to more userfriendly titles: "SYB-Manual.pdf" --> "Start Your Business - Manual" and "SYB-Business_plan.pdf" --> "Start Your Business - Business Plan"
Done
In the Improve your business folder
- Same comment as above for the PDF files in the "Improve your business" folder...remove the .pdf mentions
Done
- The download buttons like in the screenshot below don't do anything for me. Is that expected?
It's expected because kolibri does not allow downloads inside HTML5 apps. I have filled this issue to allow it conditionally in the future but this won't be possible in the short term.
The existing PDFs are training manuals for Start and improve your business where as the course they sent is a self-paced course that learners can engage in. I am wondering if adding a folder within the channel for training manuals and moving the PDFs there makes more sense?
Done
All done, apparently!!! π₯ Feels good that my comments were in line with those by @lauradanforth π
Updated locally, channel looks great and is ready to fly! π― :shipit: π
@radinamatic @revanthvle I have finished cheffing the ILO - Digitalize Your Business channel. It's ready for review. The token is daris-kutaj and the channel url in Studio is https://studio.learningequality.org/es-es/channels/0fb3424c3b8d57deacd8d4d214270be6
@rtibbles code for this channel is available at https://github.com/learningequality/sushi-chef-ilo-dyb
@jredrejo I'll confirm if the same happens on Windows, but the resources are not displaying correctly on Ubuntu 22.04 π
Firefox | Chrome |
---|---|
@radinamatic can you tell me how to reproduce it? does it happen to you in some of the lessons, in all?
Just browsing the channel in the Library, haven't even tried to put it in the lesson...
Ah, update, seems to be the case just with the first resource (Introduction - About this course), the rest open without issues... π€
thanks @radinamatic it should be fixed now
Yesssss!!! ππ½ π
I'll take another walk-through, but this should be good to go soon! π―
Hm, one more thing I noticed: after scrolling at the bottom of the resource, the last button appears (0:30 sec in the video), but then vanishes... Is it supposed to be visible (I can't seem to manage to press it fast enough to see where it goes) or you tried to make it disappear? π
@radinamatic it does not have to be visible, it's part of the code I cleaned to adapt the contents to kolibri platform. It appears for some seconds because the only way to make it disappear is.... after it appears as it's created after scrolling by the platform code. I haven't found a better way to handle it without having access to the javascript code :shrug:
Gotcha, I had an inkling that was the case. Not a blocker, imho, just making sure π
Finished testing the Digitalize Your Business channel in Firefox/Chrome on Ubuntu 22.04, and in Firefox/Chrome/Edge on Windows 11, and it's good to go! π π― π :shipit:
Thank you @radinamatic . I 'm closing this issue now. If we receive in the future more ILO contents to chef, I'll open a new issue
Overview
Prepare channels for these ILO courses:
Description and outcomes
Specs at https://docs.google.com/spreadsheets/d/18_urNiqv3DD4neteFBxfBc3ARCXv-5TRHFGFrPxnoxo/edit#gid=0