search

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
755 stars 637 forks source link

Update eslint rules to use rules from eslint/vue where possible #12199

Open rtibbles opened 1 month ago

rtibbles commented 1 month ago

Observed behavior

@MisRob created multiple custom eslint rules for Vue components, which she also contributed upstream to eslint/vue. Many of these rules are now in the main eslint/vue package.

Expected behavior

We should use these rules from upstream (e.g. https://eslint.vuejs.org/rules/no-unused-properties.html#vue-no-unused-properties) where possible, and remove the code and tests for unused rules in this repository.

shubh1007 commented 1 week ago

May I work on this issue?

rtibbles commented 1 week ago

Hi @shubh1007 - that would be great! Before work can begin fully on this, this PR https://github.com/learningequality/kolibri/pull/9698 must be merged, but we are hoping to do that this coming week.

In the meantime, looking at the existing custom rules we have for vue components, which you can find in here: https://github.com/learningequality/kolibri/tree/develop/packages/eslint-plugin-kolibri/lib/rules and then seeing which ones will be redundant once we upgrade our vue eslint plugin version (see here for the complete list: https://eslint.vuejs.org/rules/) would be a great start!

I'll assign you, and if you can make a note of which rules you think you'll need to switch over in this issue, that would be super!