search

learningequality / kolibri

Kolibri Learning Platform: the offline app for universal education
https://learningequality.org/kolibri/
MIT License
779 stars 647 forks source link

EQM: Post-bash quickfixes #12293

Closed nucleogenesis closed 3 months ago

nucleogenesis commented 3 months ago

Summary

Fixing misc simple issues I replicated after the bug bash that I didn't make an issue for:

Reviewer guidance

Make a quiz, test each of the above listed things.

github-actions[bot] commented 3 months ago

Build Artifacts

Asset type Download link
PEX file kolibri-.pex
Windows Installer (EXE) kolibri-0.17.0a0.dev0+git.142.g673706a7-windows-setup-unsigned.exe
Debian Package kolibri_0.17.0a0.dev0+git.142.g673706a7-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.17.0a0.dev0+git.142.g673706a7-0.4.2.dmg
Android Package (APK) kolibri-0.17.0a0.dev0+git.142.g673706a7-0.1.3-debug.apk
TAR file kolibri-0.17.0a0.dev0+git.142.g673706a7.tar.gz
WHL file kolibri-0.17.0a0.dev0+git.142.g673706a7-py2.py3-none-any.whl
marcellamaki commented 3 months ago

Hi @nucleogenesis - the code changes look fine, but we made a few changes to strings and also a few tweaks to functionality. Soooo, let's catch up on all the things today to see if the best path forward is rebasing this on top of develop, or just closing and refining some of the open issues and going from there.

rtibbles commented 3 months ago

I think probably only the changes to the AssignmentDetailsModal here are needed now.

rtibbles commented 3 months ago

Merging without checks due to github outage.