First pass string updates following UX writing and ditto review

marcellamaki commented 3 months ago

Summary

…

References

General updates to the add questions UI with alternative validation

When you have selected > 500 questions total

When you have a reasonable number of questions

Showing the number of replacements available

Selecting more questions that replacements available disables replacements

<= number of replacements means replacement button is enabled

…

Testing checklist

[ ] Contributor has fully tested the PR manually
[ ] If there are any front-end changes, before/after screenshots are included
[ ] Critical user journeys are covered by Gherkin stories
[ ] Critical and brittle code paths are covered by unit tests

PR process

[ ] PR has the correct target branch and milestone
[ ] PR has 'needs review' or 'work-in-progress' label
[ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
[ ] If this is an important user-facing change, PR or related issue has a 'changelog' label
[ ] If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

Automated test coverage is satisfactory
PR is fully functional
PR has been tested for accessibility regressions
External dependency files were updated if necessary (yarn and pip)
Documentation is updated
Contributor is in AUTHORS.md

github-actions[bot] commented 3 months ago

Build Artifacts

Asset type	Download link
PEX file	kolibri-.pex
Windows Installer (EXE)	kolibri-0.17.0a0.dev0+git.68.gc689e748-windows-setup-unsigned.exe
Debian Package	kolibri_0.17.0a0.dev0+git.68.gc689e748-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.17.0a0.dev0+git.68.gc689e748-0.4.2.dmg
Android Package (APK)	kolibri-0.17.0a0.dev0+git.68.gc689e748-0.1.3-debug.apk
TAR file	kolibri-0.17.0a0.dev0+git.68.gc689e748.tar.gz
WHL file	kolibri-0.17.0a0.dev0+git.68.gc689e748-py2.py3-none-any.whl

pcenov commented 3 months ago

Hi @radinamatic, As discussed here is a screenshot showing the potential confusion caused by the 'selected' word.

confusing number of questions selected vs available

Also as discussed it's currently not possible to replace questions in this build so that's blocking the testing of some scenarios:

https://github.com/learningequality/kolibri/assets/79847249/ea61d20a-b285-429a-9054-f510ba86b4a3

I'll file the other observed issues separately.

radinamatic commented 3 months ago

To add to @pcenov's comment, here is another example where the confusion is apparent:

18 selected questions were actually selected and added in previous sections, but they are also reported as selected in the new, (third) section, which did not actually have any (0 questions selected at the bottom) selected at that point. That is very confusing.

radinamatic commented 3 months ago

If we could keep the count of questions in the card referring only to questions included in the previous section(s), and the counter at the bottom referring to questions actually selected for the current section, it might alleviate the confusion.

radinamatic commented 3 months ago

And please, could we revert the default number of questions in the input field to 0? 🙏🏽

rtibbles commented 3 months ago

And please, could we revert the default number of questions in the input field to 0?

We should not default an input value to an unusable value - then it is not a default. The default of 10 is a sensible value for a reasonable number of questions to add to the section, which can save users from an extra decision if they are in a rush, which we know many of the teachers using our tools are.

rtibbles commented 3 months ago

If we could keep the count of questions in the card referring only to questions included in the previous section(s), and the counter at the bottom referring to questions actually selected for the current section, it might alleviate the confusion.

Yes, I think this makes sense - I would suggest that we update the wording on the card to X questions in quiz, Y total or something like that?

radinamatic commented 3 months ago

We should not default an input value to an unusable value - then it is not a default. The default of 10 is a sensible value for a reasonable number of questions to add to the section, which can save users from an extra decision if they are in a rush, which we know many of the teachers using our tools are.

Maybe I'm too nitpicky, but I strongly dislike (and especially in a rush) when the decisions are taken for me (and from me) by an inanimate tool (or its makers). I see the usefulness of the value 0 as the most straightforward (usable) message that the there is still a decision pending on my part on how many questions I need to add, and that I should not proceed until I make that determination. However, I guess we could only exit this impasse with a proper user testing.

rtibbles commented 3 months ago

However, I guess we could only exit this impasse with a proper user testing.

Yes, and a quick skim of all the feedback we've ever had about quizzes - we've never had a request to remove the existing default of 10 questions for a quiz, which this is a continuation of. If anything, the main requests have been asking for more automation, not less.

marcellamaki commented 3 months ago

Yes, @radinamatic I totally see what you're saying, and I think I may personally lean the same way, but I also think @rtibbles has offered a good reminder that we have gotten feedback around "plz more automatic", and that the current default behavior is 10 questions (even though, I agree that somehow it feels a bit different in this scenario). I think let's stick with it for now and see what feedback we get! We can make adjustments in 0.18, as we'll continue to update these workflows.

radinamatic commented 3 months ago

I would suggest that we update the wording on the card to X questions in quiz, Y total or something like that?

Would this be good: X questions already used, of Y previously selected? Not too long?

rtibbles commented 3 months ago

The other thing that this workflow allows, at least, is to more easily and granularly change your mind - by deleting specific questions, or adding more, so hopefully that reduces the frustration for the @marcellamaki and @radinamatic user types out there!

marcellamaki commented 3 months ago

Simplified wording on the replace questions flow:

if the the replacements are "equal" - string reflects this and button is in available state
if there are an unequal number of replacements selected (more or less) Select X to continue is displayed, and button is in inactive state